Open hamistao opened 3 weeks ago
@simondeziel For now I ask to focus the comments on the functions' behaviors. I still have some work to do on comments, docstrings and user messages.
Attention: Patch coverage is 51.16279%
with 42 lines
in your changes missing coverage. Please review.
Project coverage is 96.51%. Comparing base (
afb1b84
) to head (04b6680
). Report is 12 commits behind head on main.:exclamation: Current head 04b6680 differs from pull request most recent head d5b7f52
Please upload reports for the commit d5b7f52 to get more accurate results.
Files | Patch % | Lines |
---|---|---|
pylxd/models/storage_pool.py | 44.77% | 37 Missing :warning: |
pylxd/models/_model.py | 58.33% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@simondeziel @markylaing This is (finally) oficially ready for review
@simondeziel @markylaing This is ready for review again.
This add a few features related to custom storage volumes snapshots to pyLXD:
The unit tests will be added in a later PR if necessary. Scheduling was already supported since it is done through config key settings on the StorageVolume object. This also does some refactoring on previously existing code and some other changes made necessary by the new features and tests.