Fix using --profile flag to subcommands

canonical / python-libmaas

Unofficial python client library for MAAS

https://maas.io

Other

63 stars 71 forks source link

Fix using --profile flag to subcommands #284

Open jbott opened 2 years ago

jbott commented 2 years ago

This flag was broken, since it referenced an unset attribute profile on the parsed options object.

Yasumoto commented 2 years ago

@sparkiegeek anything we can/should do to help get this tested and (hopefully) merged? 🙏🏼

sparkiegeek commented 2 years ago

Thanks for the contribution, please can you add tests for this?

SK1Y101 commented 1 year ago

Hey @jbott! Are you still working on this/willing to work on this? If so, could you add the requested tests, and we could get this merged? that would be great!

jbott commented 1 year ago

Sorry, I no longer use MaaS. I think there is still a bug in this patch – running the command without the --profile flag was non-functional if I remember correctly (which I never bothered to fix because I only invoked it via a wrapper script).