canonical / react-components

A set of components based on Vanilla Framework
https://canonical.github.io/react-components
93 stars 51 forks source link

chore(deps): update node docker tag to v21 #1008

Closed renovate[bot] closed 7 months ago

renovate[bot] commented 7 months ago

Mend Renovate

This PR contains the following updates:

Package Type Update Change
node stage major 20 -> 21

Release Notes

nodejs/node (node) ### [`v21`](https://togithub.com/nodejs/node/blob/HEAD/CHANGELOG.md#2016-01-21-Version-426-Argon-LTS--TheAlphaNerd) Moved to doc/changelogs/CHANGELOG_V4.md#4.2.6.

Configuration

📅 Schedule: Branch creation - "on the first day of january" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

â™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.



This PR has been generated by Mend Renovate. View repository job log here.

webteam-app commented 7 months ago

Demo starting at https://react-components-1008.demos.haus

bartaz commented 7 months ago

There seem to be some issues caused by different dependencies here. On top of that our dotrun image seems to be still running node 16 which is no longer supported by some of those new dependency versions.

bartaz commented 7 months ago

Yarn install fails with:

error /workspaces/react-components/node_modules/cypress: Command failed.
Exit code: 1
Command: node index.js --exec install
Arguments: 
Directory: /workspaces/react-components/node_modules/cypress
Output:
/workspaces/react-components/node_modules/cli-truncate/index.js:3
const stringWidth = require('string-width');
                    ^

Error [ERR_REQUIRE_ESM]: require() of ES Module /workspaces/react-components/node_modules/string-width/index.js from /workspaces/react-components/node_modules/cli-truncate/index.js not supported.
Instead change the require of /workspaces/react-components/node_modules/string-width/index.js in /workspaces/react-components/node_modules/cli-truncate/index.js to a dynamic import() which is available in all CommonJS modules.
    at Object.<anonymous> (/workspaces/react-components/node_modules/cli-truncate/index.js:3:21)
    at Object.<anonymous> (/workspaces/react-components/node_modules/listr2/dist/renderer/default.renderer.js:4:21) {
  code: 'ERR_REQUIRE_ESM'

I tried downgrading cypress but it doesn't seem to help.

bartaz commented 7 months ago

Stylelint 16 is not compatible with stylelint-plugin-prettier (which says it's not needed with latest versions).

renovate[bot] commented 7 months ago

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 21.x releases. But if you manually upgrade to 21.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.