Closed huwshimi closed 3 months ago
Demo starting at https://react-components-1031.demos.haus
I made just a rough review of the
Panel
andSideNavigation
components. Maybe factor them into a dedicated PR to make it easier to review? I think those two are a bit more controversial and might need more detailed alignment and discussions.
That's a good idea, I might split this up into a number of PRs once I have it all working together.
This PR is being prevented from merging because it needs to be reviewed on Percy.
Go to Percy, find the build relevant to this PR and check if it looks as expected.
Once it's approved, add the label Review: Percy +1
to this PR.
Here are some tests I've conducted to see how these components would work in our apps:
https://github.com/canonical/lxd-ui/pull/768 https://github.com/canonical/identity-platform-admin-ui/pull/309 https://github.com/canonical/maas-ui/pull/5434 https://github.com/canonical/juju-dashboard/pull/1752 https://github.com/canonical/rebac-admin/pull/106
Creating this draft in case anyone is planning to do something similar. I haven't had time to finish this, but these components are used in Juju Dashboard and ReBAC Admin.
TODO