Closed mas-who closed 6 months ago
Demo starting at https://react-components-1034.demos.haus
Decided to move the presentation part of the component to TablePaginationControls
, then inside TablePagination
we will adjust component behaviour depending on the externallyControlled
prop. It is okay to keep usePagination
in TablePagination
actually since we just pass it with no data if externallyControlled
is true
. I think having a completely separate component for un-controlled pagination will make things a little messy and result in duplicated code.
The cool thing is that the test I wrote previously for server-pagination didn't have to change at all, so it served as a bit of a setup for TDD :slightly_smiling_face:
:tada: This PR is included in version 0.50.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Done
TablePagination
componentTablePagination
component. You can refer to the test for example usage in externally controlled mode.QA
Storybook
To see rendered examples of all react-components, run:
QA in your project
from
react-components
run:Install the resulting tarball in your project with:
QA steps
TablePagination
if server pagination works.