do not set aria-describedby attribute for the Input component if there is no help or success validation text.
do not render label element for CheckableInput if input label is empty. This resolves the issue of potentially creating labels with no text content.
QA
Storybook
To see rendered examples of all react-components, run:
yarn start
QA in your project
from react-components run:
yarn build
npm pack
Install the resulting tarball in your project with:
yarn add <path-to-tarball>
QA steps
Adjust the help and success props for the Input component on Storybook and make sure that the aria-describedby attribute is not set if both props are undefined.
Pass empty string for the label prop for RadioInput and CheckboxInput components and make sure there is no empty label element rendered.
Done
aria-describedby
attribute for the Input component if there is no help or success validation text.CheckableInput
if input label is empty. This resolves the issue of potentially creating labels with no text content.QA
Storybook
To see rendered examples of all react-components, run:
QA in your project
from
react-components
run:Install the resulting tarball in your project with:
QA steps
help
andsuccess
props for the Input component on Storybook and make sure that thearia-describedby
attribute is not set if both props are undefined.label
prop forRadioInput
andCheckboxInput
components and make sure there is no emptylabel
element rendered.