Closed bartaz closed 5 months ago
Demo starting at https://react-components-1052.demos.haus
Percy: https://percy.io/bb49709b/react-components/builds/33166994/
The expected changes are visible (Slider is fixed).
There are a lot of unrelated changes caused by Vanilla upgrade that includes new theming and new icon colours, etc.
There is also some weird behaviour in Percy that it shows new input border as lighter than before, which is weird because when checked in the browser it doesn't look lighter than before.
I'm ignoring it for now, assuming it's some Percy/Storybook glitch, but would be good to undestand the cause and if we can do anything about it, to avoid false negatives in future.
:tada: This PR is included in version 0.50.6 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Done
@includes
(vf-base
andvf-b-forms
) and@extend
uses fromMultiSelect.scss
and replaces them with copies of relevant parts of Vanilla.This is a temporary solution until we find better ways to reuse bigger parts of Vanilla styling.
@extend
usage by itself is not huge issue, but it does silently create a duplicate of Vanilla styling. Bigger problem was includingvf-base
andvf-lists
(which contain required placeholders to extend) as they duplicate big chunks of Vanilla styling creating source order conflicts of old and new styles and breaking the styling of some other components.QA steps
Fixes
Fixes: #1041