canonical / react-components

A set of components based on Vanilla Framework
https://canonical.github.io/react-components
93 stars 51 forks source link

fix(MultiSelect): Apply a temporary fix for Vanilla includes in MultiSelect component #1052

Closed bartaz closed 5 months ago

bartaz commented 5 months ago

Done

This is a temporary solution until we find better ways to reuse bigger parts of Vanilla styling. @extend usage by itself is not huge issue, but it does silently create a duplicate of Vanilla styling. Bigger problem was including vf-base and vf-lists (which contain required placeholders to extend) as they duplicate big chunks of Vanilla styling creating source order conflicts of old and new styles and breaking the styling of some other components.

QA steps

Fixes

Fixes: #1041

webteam-app commented 5 months ago

Demo starting at https://react-components-1052.demos.haus

bartaz commented 5 months ago

Percy: https://percy.io/bb49709b/react-components/builds/33166994/

The expected changes are visible (Slider is fixed).

There are a lot of unrelated changes caused by Vanilla upgrade that includes new theming and new icon colours, etc.

There is also some weird behaviour in Percy that it shows new input border as lighter than before, which is weird because when checked in the browser it doesn't look lighter than before.

image

I'm ignoring it for now, assuming it's some Percy/Storybook glitch, but would be good to undestand the cause and if we can do anything about it, to avoid false negatives in future.

github-actions[bot] commented 5 months ago

:tada: This PR is included in version 0.50.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket: