ci: Require the review of Percy visual tests

canonical / react-components

A set of components based on Vanilla Framework

https://canonical.github.io/react-components

82 stars 49 forks source link

ci: Require the review of Percy visual tests #1056

Closed bartaz closed 3 months ago

bartaz commented 3 months ago

Done

Adds a CI check that enforces Percy review and adding Review: Percy +1 label.
Adds a Review: Percy needed automatically if any files in src are changed.

QA

Check that there is no Review: Percy +1 label on the PR.
Check that CI is failing on "PR Percy Review Label Required" job
Find a bot comment describing why merging is blocked that describes what to do
Follow the comment instructions
After reviewing Percy, add Review: Percy +1 label
Make sure CI passes

webteam-app commented 3 months ago

Demo starting at https://react-components-1056.demos.haus

bartaz commented 3 months ago

Ah, thanks, forgot about this one :)

lorumic commented 3 months ago

Ah, thanks, forgot about this one :)

I rebased #1063 on main now, so it can be seen in "real" action there (meaning that some actual differences in Percy are expected for that PR). :) I hope this will not discourage people from reviewing it! :sweat_smile:

github-actions[bot] commented 3 months ago

:tada: This PR is included in version 0.51.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: