fix: stop click event propagation in Modal - Githubissues

canonical / react-components

A set of components based on Vanilla Framework

https://canonical.github.io/react-components

99 stars 55 forks source link

fix: stop click event propagation in Modal #1058

Closed vladimir-cucu closed 6 months ago

vladimir-cucu commented 6 months ago

Done

Stopped click event propagation when closing Modal and when closing or confirming ConfirmationModal.

QA

Check that Modal and ConfirmationModal renders as expected in storybook.
(optional) For example, the stop click event propagation can be tested in Juju Dashboard when opening the charm actions panel of a charm and clicking on an action. A ConfirmationModal will be rendered in a Portal. Clicking the close button used to close the panel, but, using the changes in this PR, it doesn't.

Fixes

Fixes: #1032
https://warthogs.atlassian.net/browse/WD-9915

webteam-app commented 6 months ago

Demo starting at https://react-components-1058.demos.haus

github-actions[bot] commented 6 months ago

:tada: This PR is included in version 0.51.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: