fix: tooltip should not reopen when target element is not hovered anymore

canonical / react-components

A set of components based on Vanilla Framework

https://canonical.github.io/react-components

82 stars 49 forks source link

fix: tooltip should not reopen when target element is not hovered anymore #1074

Closed edlerd closed 2 months ago

edlerd commented 2 months ago

Done

tooltip should not reopen when target element is not hovered anymore. Tooltip was running multiple timers in the background, that would reopen it after it was closed.

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

hover a tooltip and quickly move the mouse over the target element. The tooltip should close and not reopen

Percy steps

List any expected visual change in Percy, or write something like "No visual changes expected" if none is expected.

Fixes

Fixes: #1073

webteam-app commented 2 months ago

Demo

Jenkins

demos.haus

lorumic commented 2 months ago

QA steps

hover a tooltip and quickly move the mouse over the target element. The tooltip should close and not reopen

This is not clear to me. Can you add a before/after screen capture that shows how to QA?

edlerd commented 2 months ago

QA steps

hover a tooltip and quickly move the mouse over the target element. The tooltip should close and not reopen

This is not clear to me. Can you add a before/after screen capture that shows how to QA?

Before Screencast from 19.04.2024 10:40:59.webm

After Screencast from 19.04.2024 10:40:23.webm

lorumic commented 2 months ago

Checked out the branch and tested locally. The issue seems to still happen.

Peek 2024-04-19 12-29.webm

github-actions[bot] commented 2 months ago

:tada: This PR is included in version 0.51.7 :tada:

The release is available on:

Your semantic-release bot :package::rocket: