search

canonical / react-components

A set of components based on Vanilla Framework
https://canonical.github.io/react-components
82 stars 49 forks source link

fix: make EmptyState implementation consistent with Vanilla Framework #1076

Closed vladimir-cucu closed 2 months ago

vladimir-cucu commented 2 months ago

Done

Fixes

Screenshots

Screenshot from 2024-04-26 23-59-55

webteam-app commented 2 months ago

Demo

Jenkins

demos.haus

vladimir-cucu commented 2 months ago

Checked the changes in percy and am not sure why some of them are there. Checked locally the storybook differences between main and my branch, and couldn't replicate the changes spotted by percy, apart from the 2 changes related to EmptyState component.

bartaz commented 2 months ago

Checked the changes in percy and am not sure why some of them are there. Checked locally the storybook differences between main and my branch, and couldn't replicate the changes spotted by percy, apart from the 2 changes related to EmptyState component.

Yes, it looks like the diff is made by older version of main branch for some reason. I'll have a look if I can restart those to get them cleaned up.

bartaz commented 2 months ago

@vladimir-cucu I think the Percy issue is caused by the fact that your branch is likely not created from freshest main, so you are couple commits behind, making your snapshots show older versions of some components that changed in main branch.

Could you fetch and rebase on top of fresh main and push again? This should hopefully fix that.

vladimir-cucu commented 2 months ago

@vladimir-cucu I think the Percy issue is caused by the fact that your branch is likely not created from freshest main, so you are couple commits behind, making your snapshots show older versions of some components that changed in main branch.

Could you fetch and rebase on top of fresh main and push again? This should hopefully fix that.

@bartaz After rebase on top of main with latest changes and 2 more placeholder PRs to restart percy, it finally shows the expected changes!

github-actions[bot] commented 2 months ago

:tada: This PR is included in version 0.53.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: