search

canonical / react-components

A set of components based on Vanilla Framework
https://canonical.github.io/react-components
99 stars 55 forks source link

feat: add application layout components #1090

Closed huwshimi closed 3 months ago

huwshimi commented 4 months ago

Done

Note: this PR requires the follow to land first:

Original PR and discussion: https://github.com/canonical/react-components/pull/1031.

A number of tests were performed using these components:

https://github.com/canonical/lxd-ui/pull/768 https://github.com/canonical/identity-platform-admin-ui/pull/309 https://github.com/canonical/maas-ui/pull/5434 https://github.com/canonical/juju-dashboard/pull/1752 https://github.com/canonical/rebac-admin/pull/106 https://github.com/canonical/anbox-cloud-dashboard/pull/806

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

Note: the following PRs need to merge before this can be QAed:

Percy steps

Fixes

Fixes: #420.

webteam-app commented 4 months ago

Demo

Jenkins

demos.haus

huwshimi commented 4 months ago

This will fail CI until the following PRs land:

edlerd commented 3 months ago

The other PRs landed, and this one was rebased on main. There is a type confusion in the AppNavigation.stories.tsx file. I am not sure how to resolve or why it doesn't automatically pick up the right type with the icon prop. @huwshimi can you please have a look at this.

huwshimi commented 3 months ago

The other PRs landed, and this one was rebased on main. There is a type confusion in the AppNavigation.stories.tsx file. I am not sure how to resolve or why it doesn't automatically pick up the right type with the icon prop. @huwshimi can you please have a look at this.

Fixed!

huwshimi commented 3 months ago

The "Default" view in storybook for AppNavigation, AppStatus, AppAside and others are empty. Should we change those?

Fixed! I merged these with stories that had content.

github-actions[bot] commented 3 months ago

:tada: This PR is included in version 0.59.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: