feat(textarea component): Enable control+enter form submission from within a text area [WD-10959] - Githubissues

canonical / react-components

A set of components based on Vanilla Framework

https://canonical.github.io/react-components

82 stars 49 forks source link

feat(textarea component): Enable control+enter form submission from within a text area [WD-10959] #1095

Closed Kxiru closed 1 month ago

Kxiru commented 1 month ago

…ithin a text area.

Done

Added functionality such that a function pass through by "onControlEnter" (for example a submission function) can be executed when CTRL+ENTER are clicked whilst within the textarea.
Implemented a jest test to verify that the component "adds Ctrl + Enter keydown event listener on mount and removes on unmount".

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

Navigate to the textarea component.
Pres CTRL and Enter at the same time whilst within the component, and note an "alert" function occur.

Percy steps

List any expected visual change in Percy, or write something like "No visual changes expected" if none is expected.

Fixes

Fixes: # .

webteam-app commented 1 month ago

Demo

Jenkins

demos.haus

github-actions[bot] commented 1 month ago

:tada: This PR is included in version 0.55.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: