search

canonical / react-components

A set of components based on Vanilla Framework
https://canonical.github.io/react-components
95 stars 51 forks source link

Inconsistent icon direction on sortable table #1107

Closed andesol closed 19 hours ago

andesol commented 1 month ago

After https://github.com/canonical/vanilla-framework/pull/5135 that inverted the icons on the sortable table, seems like it needs to be updated on the react components as well, otherwise the direction doesn't match.

Compare this example: https://vanillaframework.io/docs/examples/patterns/tables/table-sortable?theme=light

With this one: https://canonical.github.io/react-components/?path=/story/components-maintable--sortable

jmuzina commented 1 day ago

I believe this was fixed by #1096 (React Components needed to be updated to use v4.13.0 or later. Previously React Components was using v4.11.0).

@andesol Is this issue still occurring for you?

andesol commented 19 hours ago

@jmuzina Works consistently now :+1: