canonical / react-components

A set of components based on Vanilla Framework
https://canonical.github.io/react-components
95 stars 51 forks source link

fix(Select): Add support for required attribute #1110

Open kaiweike opened 1 month ago

kaiweike commented 1 month ago

Done

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

  1. Render the Select component with the required attribute.
  2. Attempt to submit a form without selecting an option, ensuring the form validation prevents submission.
  3. Verify that removing the required attribute allows the form to be submitted without selecting an option.

Percy steps

Fixes

Fixes: #1045

webteam-app commented 1 month ago

kaiweike is not a collaborator of the repo

github-actions[bot] commented 1 month ago

This PR is being prevented from merging because it needs to be reviewed on Percy.

Go to Percy, find the build relevant to this PR and check if it looks as expected.

Once it's approved, add the label Review: Percy +1 to this PR.

kaiweike commented 1 month ago

This PR is being prevented from merging because it needs to be reviewed on Percy.

Go to Percy, find the build relevant to this PR and check if it looks as expected.

Once it's approved, add the label Review: Percy +1 to this PR.

I encountered an "Access Denied" issue while trying to access the Percy test results. It seems I don't have the necessary permissions. Could someone please assist with granting me the appropriate access? Thank you!