chore: forwardRef from SideNavigationLink component

canonical / react-components

A set of components based on Vanilla Framework

https://canonical.github.io/react-components

95 stars 51 forks source link

Closed aaryanporwal closed 2 weeks ago

aaryanporwal commented 3 weeks ago

To see rendered examples of all react-components, run:

yarn start

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

List any expected visual change in Percy, or write something like "No visual changes expected" if none is expected.

Fixes: # .

webteam-app commented 3 weeks ago

github-actions[bot] commented 2 weeks ago

:tada: This PR is included in version 1.2.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

huwshimi commented 1 week ago

This change looks like it is causing an issue as it's trying to extract the ref from the props object: https://github.com/canonical/react-components/issues/1122.

aaryanporwal commented 1 week ago

Thanks @huwshimi for reporting this. I've pushed a new fix PR #1123 can you please take a look?