Closed mcslayer closed 4 weeks ago
mcslayer is not a collaborator of the repo
Thank you, but we generally don't manage dependency updates manually. We rely on renovate to trigger update PRs for us.
But thanks for noticing that many of them were outdated. I poked on renovate to update them (https://github.com/canonical/react-components/pull/1159).
:( okay
Anyway, I suggest taking a closer look at a few specific points:
Done
ContextualMenu.stories.tsx
— problem with using nodes from the fill method without keys. Fixed by 3 separate paragraphsModularTable.stories.tsx
— problem with usingdiv
inp
. Fixed by adding a break to markdown for separate code block and paragraphSideNavigationItem.stories.tsx
— problem with usingli
inli
and with icon's place. Fixed by using args from stories in items propsTextarea.tsx
— problems with usingdefaultValue
in spread...props
, because after that we have controlled and uncontrolled textarea at the same time (value we get from state, defaultValue we get from...props
). Fixed by using separate propdefaultValue
.QA
Storybook
To see rendered examples of all react-components, run:
QA in your project
from
react-components
run:Install the resulting tarball in your project with:
QA steps
Percy steps
Fixes
Fixes: # .