canonical / react-components

A set of components based on Vanilla Framework
https://canonical.github.io/react-components
95 stars 51 forks source link

Avoid duplicate first or last page button, when total pages is one above truncateThreshold #971

Closed edlerd closed 1 year ago

edlerd commented 1 year ago

Done

QA

QA steps

webteam-app commented 1 year ago

Demo starting at https://react-components-971.demos.haus

edlerd commented 1 year ago

This looks great. It could be nice to also remove the ellipsis when on the first or last pages when all the items are displayed.

Good catch, I fixed this and added a test for this case as well.