canonical / react-components

A set of components based on Vanilla Framework
https://canonical.github.io/react-components
95 stars 51 forks source link

fix(ConfirmationModal): Use base appearance for cancel btn in ConfirmationModal #989

Closed edlerd closed 10 months ago

edlerd commented 10 months ago

Done

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

webteam-app commented 10 months ago

Demo starting at https://react-components-989.demos.haus

acarege commented 10 months ago

Hello dear team,

I think that the cancel button should be a default button for two reasons:

  1. As this is a destructive modal the main button is negative. Which means that the opposite of that action is positive. According to Vanilla we use "a default button to indicate a positive action that isn't necessarily the main call-to-action" which I think fits this case whereas "a base button... is often used alongside a default button". So according to Vanilla guidelines a default button seems more appropriate.

  2. In my personal opinion, when the "Cancel" button doesn't have borders it looks very light compared to the destructive one that is already dominant due to colours. That is something we don't want unless we're guiding user towards the destructive action.

Cheers!

bartaz commented 10 months ago

Rejected by design.