search

canonical / react-components

A set of components based on Vanilla Framework
https://canonical.github.io/react-components
95 stars 51 forks source link

Missing lodash/isEqual dep #990

Closed huwshimi closed 6 months ago

huwshimi commented 10 months ago

This package now requires lodash/isEqual but it is not included in the deps.

akmittal commented 10 months ago

This looks like a small change. Everything seem to work because lodash is still there as dependency of other packages. There also can be a eslint rule(eslint-plugin-implicit-dependencies) to prevent this in future.

Can I work on this?

huwshimi commented 10 months ago

Can I work on this?

@akmittal thanks for asking, but I actually created a PR for this, but forgot to assign and link this issue.

github-actions[bot] commented 6 months ago

:tada: This issue has been resolved in version 0.50.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: