search

canonical / react-components

A set of components based on Vanilla Framework
https://canonical.github.io/react-components
95 stars 51 forks source link

ci: Add PR linting #994

Closed petermakowski closed 10 months ago

petermakowski commented 10 months ago

Done

This PR adds a PR Lint action that enforces conventional commits convention for pull request titles.

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

Fixes

Fixes: # .

webteam-app commented 10 months ago

Demo starting at https://react-components-994.demos.haus

bartaz commented 10 months ago

@petermakowski Would it be worth documenting something what is a valid PR name? or is that clear enough when it fails?

petermakowski commented 10 months ago

Couple small questions in comments to discuss if needed, but it's fine as is as well.

Thanks, will think about updating the docs with more info next.

bartaz commented 10 months ago

Couple small questions in comments to discuss if needed, but it's fine as is as well.

Thanks, will think about updating the docs with more info next.

Thanks. I tested how it fails, and error message is quite informative, so it's not a high priority, but once we get to the point of having automatic releases set up it would be good to have the complete process described somewhere.