Closed petermakowski closed 9 months ago
Demo starting at https://react-components-995.demos.haus
All issues have been resolved and this is ready for review now @bartaz
There seem to be some breaking changes in the styling that percy surfaces: https://percy.io/bb49709b/react-components/builds/31116305/
Looks like paragraphs are rendered inside some components from Storybook? Is this some weird way of applying markdown?
Seems like this may be caused by this bug: https://github.com/storybookjs/storybook/issues/18921 There are some workarounds mentioned in the comments.
Seems like this may be caused by this bug: storybookjs/storybook#18921 There are some workarounds mentioned in the comments.
@bartaz This seems to be correct as in mdx files each new line produces a new paragraph. I'll update this PR to conform with mdx interleaving rule https://mdxjs.com/docs/what-is-mdx/#interleaving
Long term solution for this would be to move over to the new CSF story format https://storybook.js.org/docs/react/api/csf
@bartaz I fixed the failing stories manually and created an issue to follow this up and use the latest storybook story format: https://github.com/canonical/react-components/issues/1001
Seems that defaultValue
has been deprecated the in latest storybook as well, I had to make more changes to fix components docs that weren't displayed with intended values. https://storybook.js.org/docs/react/api/arg-types#defaultvalue
Done
defaultValue
from stories https://storybook.js.org/docs/react/api/arg-types#defaultvalueQA
Storybook
To see rendered examples of all react-components, run:
QA in your project
from
react-components
run:Install the resulting tarball in your project with:
QA steps
Fixes
Fixes: # .
Screenshots