canonical / rockcraft

Tool to create OCI Images using the language from Snapcraft and Charmcraft.
GNU General Public License v3.0
35 stars 43 forks source link

Migrate non-lifecycle commands to craft-application #360

Closed tigarmo closed 1 year ago

tigarmo commented 1 year ago

What needs to get done

Migrate the extensions and the init command to craft-application.

Why it needs to get done

For parity!

sergiusens commented 1 year ago

This one might be a bit tricky as we need to consider specialization, which we are just getting into (like that --flask-framework option)

tigarmo commented 1 year ago

Actually I think it's straightforward because craft-application doesn't have an init command: the migration here is basically changing the superclass of the existing InitCommand in Rockcraft from BaseCommand to AppCommand and putting it in the correct CommandGroup