chore: update to the latest craft-application

canonical / rockcraft

Tool to create OCI Images using the language from Snapcraft and Charmcraft.

GNU General Public License v3.0

37 stars 44 forks source link

chore: update to the latest craft-application #506

Closed lengau closed 7 months ago

lengau commented 8 months ago

[x] Have you signed the CLA?

This is prep work for the upcoming PR that will deal with the breaking change in https://github.com/canonical/craft-application/pull/259

lengau commented 8 months ago

@mr-cal No, I'm not sure why this PR is failing. Moved back to draft until I can fully investigate.

tigarmo commented 8 months ago

@lengau it's failing because it looks like it needs some more changes to comply with upstream:

>       return run_mocked_lifecycle(mocker=mocker, **kwargs)
E       TypeError: run_mocked_lifecycle() missing 1 required keyword-only argument: 'build_plan'

Since you're leaving for the week I can take this PR over if you want. I'll wait to work on this after craft-app 2.0 is tagged though