search

canonical / rockcraft

Tool to create OCI Images using the language from Snapcraft and Charmcraft.
GNU General Public License v3.0
37 stars 44 forks source link

feat: remove --verbose from pebble if base is 24.04 or later #526

Closed linostar closed 7 months ago

linostar commented 7 months ago

This is a subtask of https://github.com/canonical/rockcraft/pull/495. We decided to remove --verbose from base 24.04 for starters, and see the impact.

linostar commented 7 months ago

@cjdcordeiro @tigarmo Ready for review.

linostar commented 7 months ago

I think this deserves a spread test

On the way, Chef.

linostar commented 7 months ago

@tigarmo There is the odd case of base: ubuntu@22.04 with build-base: devel. It is unlikely to be used by anyone, but do you want it to be handled? and if yes, handled like 22.04 or 24.04?

tigarmo commented 7 months ago

@tigarmo There is the odd case of base: ubuntu@22.04 with build-base: devel. It is unlikely to be used by anyone, but do you want it to be handled? and if yes, handled like 22.04 or 24.04?

If you have a build-base you can always rely on it. For your specific example, the semantics are: use whatever is the current devel buildd image for the building, and ubuntu@22.04 for the target/base layer of the final rock. So it should have the new behavior.

linostar commented 7 months ago

@tigarmo There is the odd case of base: ubuntu@22.04 with build-base: devel. It is unlikely to be used by anyone, but do you want it to be handled? and if yes, handled like 22.04 or 24.04?

If you have a build-base you can always rely on it. For your specific example, the semantics are: use whatever is the current devel buildd image for the building, and ubuntu@22.04 for the target/base layer of the final rock. So it should have the new behavior.

That's what I currently opted to do. Rely on build-base if it exists, otherwise falls back to base (pun intended).

linostar commented 7 months ago

@tigarmo This should be ready for merge. The last spread test took more than 2 hours smh and failed, but the related spread tests to this PR were passing. I merged main branch into this to restart the checks.

tigarmo commented 7 months ago

@linostar @cjdcordeiro there are some new failures on chisel + 24.04 now. Unrelated to this PR but we need to look into this:

2024-04-08 07:37:57.090 :: 2024-04-08 07:37:56.518 :: 2024/04/08 07:37:56 Release date: Mon, 08 Apr 2024  6:56:37 UTC
2024-04-08 07:37:57.090 :: 2024-04-08 07:37:56.519 :: 2024/04/08 07:37:56 Fetching index for ubuntu 24.04 noble-updates main component...
2024-04-08 07:37:57.090 :: 2024-04-08 07:37:56.551 :: 2024/04/08 07:37:56 Fetching index for ubuntu 24.04 noble-updates universe component...
2024-04-08 07:37:57.090 :: 2024-04-08 07:37:56.633 :: error: slice package "liblttng-ust-common1" missing from archive
2024-04-08 07:37:57.090 :: 2024-04-08 07:37:56.643 Failed to cut requested chisel slices: dotnet-runtime-8.0_libs
linostar commented 7 months ago

@tigarmo packages.ubuntu.com seems to be partially (?) down. https://packages.ubuntu.com/noble/ is giving HTTP 500.