canonical / rockcraft

Tool to create OCI Images using the language from Snapcraft and Charmcraft.
GNU General Public License v3.0
25 stars 33 forks source link

fix: switch from progress to message for init #604

Closed sergiusens closed 1 week ago

sergiusens commented 1 week ago

tigarmo commented 1 week ago

I'm fine with the idea in principle (though we'd probably do it in craft-application instead). The problem is that by default new versions on readthedocs are private - that is, if I'm logged out I can access https://documentation.ubuntu.com/rockcraft/en/stable/ but not https://documentation.ubuntu.com/rockcraft/en/1.4.0/

And I can't seem to find a setting to change this default visibility.

sergiusens commented 1 week ago

@cjdcordeiro yes to what you say, but not now. We discussed this and we decided to do it after the rush. Also, not part of this PR per se.

sergiusens commented 1 week ago

@cjdcordeiro fwiw, I do want versioned slugs :-)

cjdcordeiro commented 1 week ago

@sergiusens fair enough. Let's then at least parameterize the doc_url in the YAML text.

Do you already have an issue somewhere with the "versioned slugs" task? (ack @tigarmo , I didn't know that either. can you please raise that issue in the #documentation channel? Btw, I can manually edit the 1.4.0 visibility and make it public, but indeed, I see that some versions are public and some are private...and I don't know if there's a way to automatically set them all to public)

sergiusens commented 1 week ago

@cjdcordeiro just did :-)

tigarmo commented 1 week ago

can you please raise that issue in the #documentation channel?

Sure, I'll do that on monday. Since we have readthedocs for business we can probably raise a support ticket