Closed gregory-schiano closed 6 days ago
Why is it Python 3.11.0rc1
? The latest version of Python 3.11 is 3.11.9, 0rc1 I think is pre-release so probably doesn't contain a bunch of security fixes etc
Btw, the docs (https://documentation.ubuntu.com/rockcraft/en/stable/tutorials/getting-started-with-flask/#chisel-the-rock) should be updated as I'm expecting the resulting rock to now be more than 15% smaller
Indeed, but not that this %age (like the size also provided in this tutorial) might change at any time due to new packages, and dependencies.
Btw, the docs (https://documentation.ubuntu.com/rockcraft/en/stable/tutorials/getting-started-with-flask/#chisel-the-rock) should be updated as I'm expecting the resulting rock to now be more than 15% smaller
Indeed, but not that this %age (like the size also provided in this tutorial) might change at any time due to new packages, and dependencies.
It was my impression, from this PR, that if you use a base: bare
, the extension will use a slice instead of a deb (which is the case today). Thus, the resulting rock will be smaller.
Btw, the docs (https://documentation.ubuntu.com/rockcraft/en/stable/tutorials/getting-started-with-flask/#chisel-the-rock) should be updated as I'm expecting the resulting rock to now be more than 15% smaller
Indeed, but not that this %age (like the size also provided in this tutorial) might change at any time due to new packages, and dependencies.
It was my impression, from this PR, that if you use a
base: bare
, the extension will use a slice instead of a deb (which is the case today). Thus, the resulting rock will be smaller.
You understood properly, but the size of the images depends on the size of the dependencies installed and the size of the files the slices are setting. This can change overtime.
Btw, the docs (https://documentation.ubuntu.com/rockcraft/en/stable/tutorials/getting-started-with-flask/#chisel-the-rock) should be updated as I'm expecting the resulting rock to now be more than 15% smaller
Indeed, but not that this %age (like the size also provided in this tutorial) might change at any time due to new packages, and dependencies.
It was my impression, from this PR, that if you use a
base: bare
, the extension will use a slice instead of a deb (which is the case today). Thus, the resulting rock will be smaller.You understood properly, but the size of the images depends on the size of the dependencies installed and the size of the files the slices are setting. This can change overtime.
Ofc it can, but in that case, we wouldn't be stating any sizes anywhere, and we are (64MB , and then 15% reduction). You do agree that, with your changes, the size reduction will no longer be 15% right? If that's true, then the doc needs fixing
Btw, the docs (https://documentation.ubuntu.com/rockcraft/en/stable/tutorials/getting-started-with-flask/#chisel-the-rock) should be updated as I'm expecting the resulting rock to now be more than 15% smaller
Indeed, but not that this %age (like the size also provided in this tutorial) might change at any time due to new packages, and dependencies.
It was my impression, from this PR, that if you use a
base: bare
, the extension will use a slice instead of a deb (which is the case today). Thus, the resulting rock will be smaller.You understood properly, but the size of the images depends on the size of the dependencies installed and the size of the files the slices are setting. This can change overtime.
Ofc it can, but in that case, we wouldn't be stating any sizes anywhere, and we are (64MB , and then 15% reduction). You do agree that, with your changes, the size reduction will no longer be 15% right? If that's true, then the doc needs fixing
Sure agree, that was just a side note. I've already updated the doc, we went from 65MB to 46MB, so 30% less
For reference, the ubuntu 22.04 base leads to a 65MB image, while the bare base image (with python3.10) leads to a 44MB image size
Thanks a lot! Does anyone else want to look into this before I sync it with main & merge?
@tigarmo please wait for a check on the documentation. Is https://documentation.ubuntu.com/rockcraft/en/stable/reference/extensions/flask-framework/ up to date after this merge?
If the rockcraft.yaml accurate?
@tigarmo please wait for a check on the documentation. Is https://documentation.ubuntu.com/rockcraft/en/stable/reference/extensions/flask-framework/ up to date after this merge?
If the rockcraft.yaml accurate?
I didn't change anything about the user experience. The documentation update needed was about the size reduction of the produced chiseled rock. I've done a review of the existing documentation to ensure something needs to be updated, and didn't find anything else. But could be good to have a second pair of eyes
Using the new
python3.11-venv
slice to reduce the image of the generated rock when base isbare
usingflask-framework
anddjango-framework
extensions.How to test: Install a build of rockcraft using this branch, you need to have
docker
installed tooYou can also test using the tutorial (follow the chiseling part of the tutorial): https://documentation.ubuntu.com/rockcraft/en/latest/tutorials/getting-started-with-flask/