search

canonical / rockcraft

Tool to create OCI Images using the language from Snapcraft and Charmcraft.
GNU General Public License v3.0
37 stars 44 forks source link

fix: craft-cli branch ref to main #622

Closed yanksyoon closed 4 months ago

yanksyoon commented 4 months ago

Fixes: https://github.com/canonical/rockcraft/issues/621

yanksyoon commented 4 months ago

Tests are failing due to ref to rockcraft branch in the craft-application. PR: https://github.com/canonical/craft-application/pull/369

tigarmo commented 4 months ago

We'll fix this soon with properly released versions of the tools. May I ask why you need development rockcraft?

yanksyoon commented 4 months ago

@tigarmo thank you! Shall I close the PRs related to the this issue? The reason I need these are for our operator workflows: https://github.com/canonical/operator-workflows/pull/370 in which we have a test to clone rockcraft repo and build it ourselves and use the built rockcraft to pack our rocks. This is to test the feature where we can specify rockcraft refs.

tigarmo commented 4 months ago

@tigarmo thank you! Shall I close the PRs related to the this issue?

Yes, please. And thanks for the help ;)

This is to test the feature where we can specify rockcraft refs.

Ah, I see. In that case, my (unsolicited) suggestion is that you use a tag as ref instead, like 1.4.0. We don't plan on breaking main again but well, you never know hehe

yanksyoon commented 4 months ago

Will do! Thank you!