This PR removes tests that validate bundle content. This may feel "wrong" at first but it's the right thing IMO. Note that we are keeping the lib tests that validate the bundle generation logic but nothing sdcore specific.
Rationale
We were maintaining both the logic to generate the bundles and the expected bundles themselves. The artifact that this project creates are bundles so why have the whole logic to generate bundles if we are maintaining the expected bundles too. This brings us to 2 options:
Keep the logic to generate bundles, have test that validates the logic and trust that the expected bundles are correct.
Keep the expected bundles and simply upload those
I'm pretty confident about the code that generates the bundles now so it feels like the right time to drop the "expected" bundles.
Description
This PR removes tests that validate bundle content. This may feel "wrong" at first but it's the right thing IMO. Note that we are keeping the
lib
tests that validate the bundle generation logic but nothing sdcore specific.Rationale
We were maintaining both the logic to generate the bundles and the expected bundles themselves. The artifact that this project creates are bundles so why have the whole logic to generate bundles if we are maintaining the expected bundles too. This brings us to 2 options:
Checklist: