TPMDeviceAttributes.FirmwareVersion should be uint64

canonical / secboot

9 stars 15 forks source link

TPMDeviceAttributes.FirmwareVersion should be uint64 #6

Closed chrisccoulson closed 5 months ago

chrisccoulson commented 4 years ago

Although the format of the firmware version is manufacturer specific, it is represented in the TPM as a uint64. The parseTPMDeviceAttributesFromDirectoryName() function in tpm.go extracts the firmware version from the EK certificate, but currently interprets this as a uint32, which isn't correct.

chrisccoulson commented 5 months ago

Closing this given that this code is being removed in https://github.com/snapcore/secboot/pull/273