search

canonical / seldon-core-operator

Seldon Core Operator
Apache License 2.0
5 stars 10 forks source link

fix: Parse custom images with ":" in their name #206

Closed phoevos closed 1 year ago

phoevos commented 1 year ago

For some of the images, the charm attempts to separate the image name from the tag, splitting the string in two using : as a separator. However, this breaks the installation if the image name contains that special character, which could be the case if a local container registry address is provided for instance (e.g. 172.17.0.2:5000/tensorflow/serving:2.1.0).

Use rsplit to ensure that the rightmost part of the string (following the last :) is parsed as the tag.

Closes #205

phoevos commented 1 year ago

Looks like we're bumping into this: https://github.com/canonical/seldon-core-operator/issues/203