search

canonical / seldon-core-operator

Seldon Core Operator
Apache License 2.0
5 stars 10 forks source link

Assert `test_seldon_servers.py` based on response status and structure #239

Open orfeas-k opened 8 months ago

orfeas-k commented 8 months ago

Context

The tests assert the exact results returned from a SeldonDeployment. However, neither our charm neither using ROCKs instead of upstream images should be able to break the seldonDeployments results, as long as they actually return a successful response. Thus, tests should assert that the response is a successful one and that they actually contain results.

What needs to get done

Modify tests assertion

Definition of Done

Tests assert based on response status and structure instead of specific results.

syncronize-issues-to-jira[bot] commented 8 months ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5309.

This message was autogenerated