search

canonical / seldonio-rocks

ROCKs for Seldon Core
Apache License 2.0
0 stars 1 forks source link

feat: Seldon rock integration #12

Closed i-chvets closed 1 year ago

i-chvets commented 1 year ago

NOTE: This PR description only contains information related to code changes and testing, if required. All detailed information about problem statement, design, implementation, technical discussions, etc. is tracked in corresponding Github issue indicated below. This will ensure that important information is reliably recorded and tracked and not scattered across PR(s).

Details Refer to the following Github issue for more information on feature/fix that this PR is related to: https://github.com/canonical/seldon-core-operator/issues/133

Summary of changes:

NOTE: Use of bash shell commands significantly reduces maintability of tox.ini ACK: @kimwnasptd

i-chvets commented 1 year ago

CheckRock test class: https://github.com/canonical/charmed-kubeflow-chisme/pull/56

i-chvets commented 1 year ago

@DnPlas @kimwnasptd Let's resolve/approve this issue.

i-chvets commented 1 year ago

@DnPlas @kimwnasptd Reverted to use of bash shell sripting and yq instead of CheckRock test class. Ready for approval.