search

canonical / seldonio-rocks

ROCKs for Seldon Core
Apache License 2.0
0 stars 1 forks source link

feat: Update `on_pull_request` and introduce `on_push` workflow #74

Closed orfeas-k closed 10 months ago

orfeas-k commented 10 months ago

Update repo's CI according to changes introduced in PR https://github.com/canonical/charmed-kubeflow-workflows/pull/36. This could be considered a follow up PR to https://github.com/canonical/seldonio-rocks/pull/64 that closed https://github.com/canonical/seldonio-rocks/issues/58.

After this PR, automation will be set up according to https://github.com/canonical/charmed-kubeflow-workflows/issues/31#issuecomment-1851982000.

NohaIhab commented 10 months ago

should we also update build_and_publish_rock.yaml and build_and_scan_rocks.yaml according to the latest changes?

orfeas-k commented 10 months ago

Pushed a commit for build_and_publish.yaml. Regarding build_and_scan_rocks.yaml, this should be an effort of its own https://github.com/canonical/bundle-kubeflow/issues/782. At the moment, we know that this fails and I 'm not sure if we want to have daily building and scanning (short summary: what's the point of rebuilding and scanning? shouldn't we scan images that are already published? This happens already though here.