fix tests: Until now, tests didn't actually test the ROCK (but used the upstream image) since we didn't properly replace the server's image in the charm's configmap.
Add entrypoint-service:tensorflow-serving along with required [ args ] in command field to address #83
Use rockcraft-channel: latest/edge in CI (that affects the whole repo) since entrypoint-service field was introduced in 1.1.0 which is not yet published to stable rockcraft snap. Otherwise, it would fail with
Tests
Tests still fail due to #86. This doesn't look like a major result error and is probably related to round-offs. Thus, I suggest we merge this PR and publish manually the ROCK built in the CI. Once this is done, we 'll update the seldon-server tests accordingly.
configmap
.entrypoint-service:tensorflow-serving
along with required[ args ]
incommand
field to address #83Userockcraft-channel: latest/edge
in CI (that affects the whole repo) sinceentrypoint-service
field was introduced in 1.1.0 which is not yet published tostable
rockcraft snap. Otherwise, it would fail withTests
Tests still fail due to #86. This doesn't look like a major result error and is probably related to round-offs. Thus, I suggest we merge this PR and publish manually the ROCK built in the CI. Once this is done, we 'll update the seldon-server tests accordingly.
Closes #83