canonical / snap-openstack-hypervisor

Apache License 2.0
0 stars 3 forks source link

Add libvirt exporter service #2

Closed chanchiwai-ray closed 1 year ago

chanchiwai-ray commented 1 year ago

As part of the COS integration, this PR adds the libvirt exporter service to the snap, and also add snap configuration option to enable / disable exporter services. By default, the exporter services are disabled until the monitoring.enable is set to true.

Related to: https://review.opendev.org/c/openstack/charm-openstack-hypervisor/+/893007 PR Migrated from https://github.com/openstack-snaps/snap-openstack-hypervisor/pull/32

jneo8 commented 1 year ago

James Lin confirmed https://github.com/Tinkoff/libvirt-exporter has little bit more metrics than https://opendev.org/vexxhost/libvirtd_exporter

Even Tinkoff/libvirt-exporter is public archive, we currently think Tinkoff one export more information than vexxhost one. We don't have a strong reason to use it.

chanchiwai-ray commented 1 year ago

I would say both projects are archived because https://opendev.org/vexxhost/libvirtd_exporter is using archived libvirt library

chanchiwai-ray commented 1 year ago

Rebased onto main branch