search

canonical / snap-vault

Vault is a tool for securely accessing secrets
https://snapcraft.io/vault
Other
16 stars 10 forks source link

vault 1.5.x < 1.5.4 reports incorrect version #26

Closed aieri closed 3 years ago

aieri commented 3 years ago

Vault just got refreshed to version 1.5.3, but something must have gone wrong with the snap build:

# snap list vault
Name   Version  Rev   Tracking       Publisher   Notes
vault  1.5.3    1930  latest/stable  canonical✓  -

# curl -s http://127.0.0.1:8220/v1/sys/health?standbyok=true | jq '.version'
"1.5.0"

# /snap/vault/current/bin/vault --version
Vault v1.5.0 (cgo)
afreiberger commented 3 years ago

This is due to upstream missing minor rev update:

https://github.com/hashicorp/vault/blob/v1.5.3/sdk/version/version_base.go#L11

This is also set to the same 1.5.0 string as in the releases/1.5.x branch.

Bug should be sent upstream to hashicorp.

afreiberger commented 3 years ago

I'm also thinking that this repo should reference the 1.5.3 tag in snapcraft.yaml rather than the modifiable releases/1.5.x branch.

aieri commented 3 years ago

Done.

It may be worth leaving this issue open to track needing to rebuild the snap as soon as 1.5.4 will be out.

taodd commented 3 years ago

The issue is fixed in vault 1.5.4 and was just got released, need to rebuild the snap with this version

javacruft commented 3 years ago

1.5.4 in candidate for testing

javacruft commented 3 years ago

1.5.4 released to stable channel