search

canonical / snapcraft-rocks

Sources for Snapcraft as OCI images, maintained by the Starcraft team
GNU General Public License v3.0
4 stars 1 forks source link

feat: support build-packages #8

Closed tigarmo closed 7 months ago

tigarmo commented 7 months ago

NOTE: The first two commits can be skipped because this PR is built on top of #6

The cause of the problem is that the base Ubuntu image used by the Snapcraft rock has an empty Apt cache. This makes sense for application images which don't expect to use/need Apt, but is a problem for a build tool like Snapcraft.

The fix in this commit is to add a "wrapper" script that first calls "apt update" to populate the cache, and then execs Snapcraft as normal.

cmatsuoka commented 7 months ago

Looks good, but a test failed.

tigarmo commented 7 months ago

Looks good, but a test failed.

thanks! I was waiting for the review to rebase this, after the rebase it should pass.