No API error handling on /store categories

canonical / snapcraft.io

The official website's repository for the Snap store

https://snapcraft.io/

Other

145 stars 108 forks source link

No API error handling on /store categories #1922

Open bartaz opened 5 years ago

bartaz commented 5 years ago

Expected behaviour

If API fails for any reason (cache, network, etc) it would be nice to have some error handling - not show category at all, show error, or something. Currently it renders empty category with 'undefined' in place of snaps:

pmahnke commented 5 years ago

I would u-hide the entire category, assuming that some appear

tbille commented 5 years ago

@bartaz maybe some kind of reload button since this call is made from the browser?

bartaz commented 5 years ago

Reload can be done from browser.

As Peter suggests, I think it would be fine just to hide category that failed - of course assuming other are displayed. If everything fails some error message would be good.