canonical / snapcraft

Package, distribute, and update any app for Linux and IoT.
https://snapcraft.io
GNU General Public License v3.0
1.18k stars 445 forks source link

snapcraft 8.2.0.post3+gitc9ab9d1d from edge doesn't support refresh-mode: ignore-running #4747

Closed kenvandine closed 6 months ago

kenvandine commented 6 months ago

Bug Description

The documentation shows ignore-running as a valid option for refresh-mode

https://snapcraft.io/docs/snapcraft-app-and-service-metadata

However when building snapcraft reports:

unexpected value; permitted: 'endure', 'restart'

To Reproduce

Add "refresh-mode: ignore-running" to the app

Environment

snapcraft from edge with lxd

snapcraft.yaml

+    refresh-mode: ignore-running

Relevant log output

unexpected value; permitted: 'endure', 'restart'

Additional context

No response

syncronize-issues-to-jira[bot] commented 6 months ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-2834.

This message was autogenerated

mr-cal commented 6 months ago

Thanks for the report! I can reproduce this in snapcraft 7.x/stable and 8.x/stable with core20 and core22.

@kenvandine, was this previously working for you?

It appears that it should have never worked (source and source). Here's my core22 reproducer:

name: test
version: '0.1'
summary: test
description: test

grade: devel
confinement: devmode

base: core22

parts:
  my-part:
    plugin: nil
    override-build: |
      touch $CRAFT_PART_INSTALL/hello
      chmod +x $CRAFT_PART_INSTALL/hello
      craftctl default

apps:
  my-app:
    command: hello
    refresh-mode: ignore-running
kenvandine commented 6 months ago

No, I didn't know about it until I just stumbled upon it in the docs and thought it could solve a problem we have right now.

mr-cal commented 6 months ago

Great, I was hoping for. I'll update the models to allow ignore-running.