fix: re-register dotnet for core22

mr-cal commented 3 months ago

[x] Have you followed the guidelines for contributing?
[x] Have you signed the CLA?
[x] Have you successfully run tox run -m lint?
[x] Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

re-register dotnet for core22
add core22 and core24 dotnet spread tests
refactor Application to allow snapcraft to register/unregister plugins per-base
- this includes renaming _known_core24 to _known_craft_app_base in preparation for core26

Fixes #4825 (CRAFT-2979)

mr-cal commented 3 months ago

Force-pushed because I dropped all changes related to running the ClassicFallback or craft-application based codepath.

It's too disruptive of a change for a hotfix.

mr-cal commented 3 months ago

We can generalize the calls a bit more instead of being core24-specific in a future refactoring, but this solves the reported issue.

Agreed. In a point release, we should flip the paradigm such that the craft-application codepath is used by default and Snapcraft only raises ClassicFallback if we know we should use the core20 or core22 feature set.

canonical / snapcraft

fix: re-register dotnet for core22 #4841