desktop: stop renaming desktop file

soumyaDghosh commented 3 days ago

With snapd 2.66, it supports custom desktop file names. This patch allows it to happen from snapcraft side.

[x] Have you followed the guidelines for contributing?
[x] Have you signed the CLA?
[x] Have you successfully run tox run -m lint?
[x] Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

soumyaDghosh commented 3 days ago

Do you know what effect this will have when running a snap on a system with snapd<2.66?

As I tested before, snapd will install the file with a , which snapd will do here also if the desktop file names aren't explicitly mentioned before hand. It was never really an issue to fix with.

soumyaDghosh commented 3 days ago

I think I'll need to fix the spread tests too.

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (feature/desktop-files@c7d11ac). Learn more about missing BASE report.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## feature/desktop-files #5150 +/- ## ======================================================== Coverage ? 89.71% ======================================================== Files ? 342 Lines ? 22641 Branches ? 0 ======================================================== Hits ? 20312 Misses ? 2329 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

canonical / snapcraft

desktop: stop renaming desktop file #5150

Codecov Report