CI should ignore files, which are not related with source code or CI/CD

canonical / solutions-engineering-automation

Repo for automating tasks for Solutions Engineering Team.

1 stars 5 forks source link

CI should ignore files, which are not related with source code or CI/CD #60

Open rgildein opened 3 months ago

rgildein commented 3 months ago

I think that it's not important to run CI on changes which are not related to the charm/snap/... . For example in this PR we are changing code-owners and that's do not change anything on snap.

Maybe we can ignore files/directories:

pyproject.toml, only lint tests
.github/CODEOWNERS
.github/.jira_sync_config.yaml
.gitignore
CONTRIBUTING.md
docs/*

This list is only suggestion, and we should check it properly.

samuelallan72 commented 2 months ago

This sounds useful, and we already ignore .md and .rst files. I think we can be conservative here, and add some well known, somewhat frequently updated files. :)

samuelallan72 commented 2 months ago

Although the flip side is it's too easy to accidentally ignore a file where changing it could break something (eg. with the current config, a markdown file might be read by setup.py for the description for example); it's not that inefficient to just always run the tests; and we can always request merge without waiting for the tests if it's something really simple.