Fix bug with One not checking for errors and others

canonical / sqlair

Friendly type mapping for SQL databases

Apache License 2.0

16 stars 9 forks source link

Closed Aflynn50 closed 1 year ago

Aflynn50 commented 1 year ago

I found a few bugs while testing. These were:

If there is an error with the SQLair syntax in the query run with One() it will return ErrNoRows rather than that error, there was also no check for a query error at the start of One, this has been fixed by adding in an error check to the q function in Query.
There was also a possible error with Decode not checking for iter.rows == nil. I've added a check for this and tests for the method order.

niemeyer commented 1 year ago

As we discussed, let's please drop the use of closures in the query. This bug will be fixed as a side effect.