Better errors 2 - Githubissues

canonical / sqlair

Friendly type mapping for SQL databases

Apache License 2.0

17 stars 8 forks source link

Better errors 2 #61

Closed Aflynn50 closed 11 months ago

Aflynn50 commented 1 year ago

This PR contains some minor improvements to errors/testing across the codebase. These are:

Change if err != nil { c.Fatal(... to c.Assert(err, IsNil)
Change table tests in expr_test.go to use c.Assert instead of if and c.Errorf
Minor rewording to some error messages
An error for missing SQLair columns in the results (this could happen if an output expression was put inside a WITH clause)
Add a elemName field to typeMember which contains the field tag or map key to be used in error messages.
Tidy up some tests

This PR contains #86, #87 and #88