search

canonical / starbase

A base repository for packages from the Starcraft team
GNU Lesser General Public License v3.0
9 stars 5 forks source link

ci: use starflow CI actions #272

Closed lengau closed 1 week ago

lengau commented 1 month ago

CRAFT-3603

Depends on https://github.com/canonical/starflow/pull/18

tigarmo commented 1 month ago

@lengau I think I'll do the review starting from the final UI; let me know if this is too unreadable: image

tigarmo commented 1 month ago

also @lengau can you break a test so we see what a failed run looks like?

lengau commented 1 month ago

@tigarmo thanks for the review!

For the questions you asked:

  1. I can name the step whatever I want, so I can do that. (commit incoming)
  2. I don't think I can hide that output in a composite action. The only way I can see being able to do it is by putting it into a separate step in a reusable workflow. I'm not sure I'm particularly happy with the reusable workflow I came up with for this earlier though: https://github.com/canonical/starflow/pull/10/files
  3. I'm trying a notice message - not sure whether it'll work, will report back.
  4. While this isn't a broken test (it was broken coverage), this has the same effect: https://github.com/canonical/starbase/actions/runs/11469498939/job/31916844851