search

canonical / stsstack-bundles

8 stars 25 forks source link

Pre-allocate func test vip ports #271

Open dosaboy opened 3 weeks ago

dosaboy commented 3 weeks ago

Resolves: #269

rodrigogansobarbieri commented 3 weeks ago

Who de-allocates the ports? Also, doesn't commit [1] prevent the issue altogether?

[1] https://github.com/canonical/stsstack-bundles/commit/50e87ed37e48cbd168827a9096a7d58c618f2684

dosaboy commented 3 weeks ago

Who de-allocates the ports? Also, doesn't commit [1] prevent the issue altogether?

[1] 50e87ed

do we want to de-allocate the ports? i mean im fine to do so but just not sure its necessary since they will always use the same address. now that you mention it though this will potentially cause issues with the main vip code used for deployments so i guess de-allocation makes sense.

dosaboy commented 2 weeks ago

I have reviewed the tools_allocate_vips.sh script. Currently it is not called from anywhere so is not integrated. It is also use specific IP addresses which as @brianphaley points out is no longer necessary but in fixing that in the rest of stsstack-bundles is going to be a not-so-insignificant patch so what I have done is used a port naming convention compatible with that script and will follow up with a patch to fix the wider issue which when done will mean we can remove this implementation (which is now much simpler than before btw).