canonical / tempo-k8s-operator

https://charmhub.io/tempo-k8s
Apache License 2.0
5 stars 3 forks source link

flipped tracing directionality #35

Closed PietroPasotti closed 1 year ago

PietroPasotti commented 1 year ago

Tempo becomes provider of tracing.

Tandem PRs:

PietroPasotti commented 1 year ago

@shipperizer keep an eye on this please dangers of early adoption :)

shipperizer commented 1 year ago

is it backwards incompatible?ETA for the merge? anyway got the tickets added in the backlog and we'll tackle this next sprint (from monday)

thanks for the heads up @PietroPasotti

PietroPasotti commented 1 year ago

is it backwards incompatible?ETA for the merge? anyway got the tickets added in the backlog and we'll tackle this next sprint (from monday)

thanks for the heads up @PietroPasotti

Starting tomorrow I'm off until September, so you'll need to coordinate with @simskij and @sed-i on how to handle this, probably you should synchronize with this, prometheus and traefik else the cos-lite edge deployment will be briefly degraded (but hopefully it won't explode)

PietroPasotti commented 1 year ago

holding off the merge for now given the above

bencekov commented 1 year ago

I'm having trouble packing the charm on this branch. I get this error:

ERROR: Double requirement given: opentelemetry-exporter-otlp-proto-grpc (from -r requirements.txt (line 10)) (already in opentelemetry-exporter-otlp-proto-grpc==1.17.0, name='opentelemetry-exporter-otlp-proto-grpc')

I checked the requirements files, but to me it doesn't seem like there are multiple imports.

Anyone else has issues like this?