search

canonical / tempo-k8s-operator

This charmed operator automates the operational procedures of running Grafana Tempo, an open-source tracing backend.
https://charmhub.io/tempo-k8s
Apache License 2.0
5 stars 3 forks source link

pydantic v2 support #51

Closed PietroPasotti closed 7 months ago

PietroPasotti commented 7 months ago

this PR adds pydantic v2 support

PietroPasotti commented 7 months ago

Come to think of it, given we're effectively breaking BC and possibly introducing incompatibilities if you try and use this together with another charm (lib) that requires pydantic<2, should we actually be bumping the major? @simskij @mmkay

sed-i commented 7 months ago

Come to think of it, given we're effectively breaking BC and possibly introducing incompatibilities if you try and use this together with another charm (lib) that requires pydantic<2, should we actually be bumping the major? @simskij @mmkay

Yeah, this PR should probably have quite a few tandem PRs.

mmkay commented 7 months ago

Integration tests might still need to be adjusted to use the bumped version.