fixed tracing and charm-tracing libs - Githubissues

canonical / tempo-k8s-operator

This charmed operator automates the operational procedures of running Grafana Tempo, an open-source tracing backend.

https://charmhub.io/tempo-k8s

Apache License 2.0

5 stars 3 forks source link

fixed tracing and charm-tracing libs #86

Closed PietroPasotti closed 3 months ago

PietroPasotti commented 3 months ago

Issue

Fixes #85 Also slightly adjusts the behaviour of tracing on the get_endpoint path:

when deciding whether to raise an exception (when checking for requests if there is no response yet), tolerate empty databags
only search for responses in the specific relation you're get_endpointing from, instead of all of them, if you provided one

Solution

bumps for tracing and charm_tracing

added a bunch of tests covering all leadership/remote data provided combinations

Testing Instructions

itests should take care of most of it, but we should test it with cos-lite to be sure.

Quick test on an existing cos-lite:

jhack sync -S tempo
jhack sync -S traefik
touch ./lib/charms/tempo_k8s/v1/tracing.py  
juju remove-relation traefik tempo:tracing
juju relate traefik tempo:tracing
jhack show-relation traefik tempo:tracing